[FusionDev] [fusion-commits] Animation plugin: Changes to 'master' (aae9f7c6dd71de1662a0ec1662b508f203dc3a7c)

[Erkin Bahceci]

On Jan 27, 2008 4:49 PM, Kristian Lyngstøl <kristian at bohemians.org> wrote:
> On 23 Jan 2008 17:24:00 -0000,  <cornelius at server.beryl-project.org> wrote:
> (...)
> > --- fusion/plugins/animation/animation.c
> > +++ fusion/plugins/animation/animation.c
> > @@ -3202,6 +3202,19 @@ animGetWindowName (CompWindow *w)
> >
> > +// Don't animate windows that don't have a pixmap or certain properties,
> > +// like the fullscreen darkening layer of gksudo
> > +// or the darkening layer of x-session-manager
> > +static inline Bool
> > +ignoreForAnimation (CompWindow *w, Bool checkPixmap)
> > +{
> > +    ANIM_WINDOW(w);
> > +
> > +    return ((checkPixmap && !w->texture->pixmap) ||
> > +           !(w->resName || windowHasUserTime (w)) ||
> > +           (aw->wmName && strcasecmp (aw->wmName, "x-session-manager") == 0));
> > +}
> > +
>
> I like your comments, but it would be helpfull if you pointed out the
> expected return value. (IE: Return true if the window should be
> ignored).
>


Thanks for the feedback. I made some clarification.


>
> Variable declarations should be at the top of the scope for clarity.
>
> - Kristian aka The Nitpicker ;)


I can understand, being a nitpicker myself ^^.

- Erkin