[FusionDev] [Bug 628] Check return codes everywhere

[bugzilla at bugs.opencompositing.org]

http://bugs.opencompositing.org/show_bug.cgi?id=628





--- Comment #7 from Markus Elfring <Markus.Elfring at web.de>  2007-11-19 11:40:27 ---
(In reply to comment #6)
> Changing int to size_t seams to me unnecessary, your patch would be
> more likely to be accepted, if you revert that back.

The return type of the function "strlen" is not "signed int".


> A good practice, wether to check or not check the return value is, if you have
> checked 80% of the occurance of that function the return value, then it's most
> likely a bug, if you don't check the remaining... 

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?


> Checking return value of fprintf(stderr, doesn't make sense, or printf() in
> usage(). It doesn't hurt internally and if that doesn't work, then it's really
> time to reboot.

Do you care for failed output and log messages?


> For the compiz bugs itself, you can alternativly submit the bug
> to upstream http://bugs.freedesktop.org/

This relationship is not clear for me.
Are there any open issues still inherited from there?


> (Falls du eine 2. Meinung haben möchtest)

Ich bin sehr an mehreren Meinungen für die Fehlerbehebung interessiert ...


-- 
Configure bugmail: http://bugs.opencompositing.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.