[FusionDev] [Bug 628] Check return codes everywhere

[bugzilla at bugs.opencompositing.org]

http://bugs.opencompositing.org/show_bug.cgi?id=628


Kristian Lyngstøl <kristian at bohemians.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kristian at bohemians.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #3 from Kristian Lyngstøl <kristian at bohemians.org>  2007-11-17 22:20:13 ---
ini is not maintained here. Open individual tickets for individual patches.
Patches like this will be accepted as they are easy to verify. We do not need
"examples". We are well aware that there are countless places in the code where
there is room for improvements. 

I take it you are not aware, but your constant bickering about what to most of
us is irrelevant with points to details and refferences to standards makes you
come off as overly condescending. I advice you to take ONE ISSUE AT A TIME, one
specific case at a time, and use the mailing list to affect general coding
style, not the bug tracker. 

Using the bug tracker for specific patches is welcomed, we do not generally
(nor will most other projects) accept large patches from people we are not
familiar with, even if it is a collection of trivial changes. 

If you want an example of how to achieve your changes, search for Roland Baer's
work both on this bug tracker and in the git repositories. 

Since I am not at home so I can't commit to compiz at the moment, I can't
accept your ini patch. There are several people in the compiz fusion project
with Compiz commit access, and we do occasionally accept patches and bugs for
compiz here, but in general they should be sent to the compiz mailing list.
When creating patches, you should use git-format-patches, I think you will find
that it makes it easier for you to create several patches out of the same issue
with little effort, which is something that will come in handy if you intend to
fix the issues you point out.

At last, I would like to emphasis that you try using the mailing list for your
general coding style changes; most of us do see the points you are making, we
just don't find solving the existing implementation very appealing. However,
the best way of achieving coding style changes is to make an example in the
work you do. 

I hope this helps. It has not been my intention to ignore your tickets or shove
them aside, even as I close them. I leave this open for the ini-patch. I'll
commit it when I get home on sunday if nobody beats me to it.


-- 
Configure bugmail: http://bugs.opencompositing.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.